rework tests

spec/models/user_spec.rb

@@ -1,105 +1,59 @@
 require "rails_helper"
 
 describe User, type: :model do
+  before { @user = create(:user) }
 
-  it "should be valid." do
-    user = create(:user)
-    expect(user).to be_valid
-  end
+  context 'validations' do
+    it { should validate_presence_of(:name) }
+    it { should validate_length_of(:name).is_at_most(24) }
 
-  it "name should be present." do
-    user = build(:user, name: nil)
-    expect(user).to_not be_valid
-  end
+    it { should validate_presence_of(:provider) }
 
-  it "username should be present." do
-    user = build(:user, username: nil)
-    expect(user).to_not be_valid
-  end
+    it { should validate_uniqueness_of(:email).case_insensitive }
+    it { should validate_length_of(:email).is_at_most(60) }
+    it { should allow_value("", nil).for(:email) }
+    it { should allow_value("valid@email.com").for(:email) }
+    it { should_not allow_value("invalid_email").for(:email) }
 
-  it "provider should be present." do
-    user = build(:user, provider: nil)
-    expect(user).to_not be_valid
-  end
+    it { should allow_value("valid.jpg").for(:image) }
+    it { should allow_value("valid.png").for(:image) }
+    it { should_not allow_value("invalid.txt").for(:image) }
+    it { should allow_value("", nil).for(:image) }
 
-  it "should allow nil email." do
-    user = build(:user, email: nil)
-    expect(user).to be_valid
-  end
+    context 'is greenlight account' do
+      before { allow(subject).to receive(:greenlight_account?).and_return(true) }
+      it { should validate_presence_of(:password) }
+      it { should validate_length_of(:password).is_at_least(6) }
+    end
 
-  it "should allow nil uid." do
-    user = build(:user, uid: nil)
-    expect(user).to be_valid
-  end
-
-  it "should allow nil password." do
-    user = build(:user, password: nil, password_confirmation: nil)
-    expect(user).to be_valid
-  end
-
-  it "password should be longer than six characters." do
-    user = build(:user, password: "short")
-    expect(user).to_not be_valid
-  end
-
-  it "should create user from omniauth." do
-    auth = {
-      "uid" => "123456789",
-      "provider" => "twitter",
-      "info" => {
-        "name" => "Test Name",
-        "nickname" => "username",
-        "email" => "test@example.com"
-      }
-    }
-
-    user = User.from_omniauth(auth)
-
-    expect(user.name).to eql(auth["info"]["name"])
-    expect(user.username).to eql(auth["info"]["nickname"])
-  end
-
-  it "email addresses should be saved as lower-case." do
-    mixed = "ExAmPlE@eXaMpLe.CoM"
-
-    user = build(:user, email: mixed)
-    user.save
-
-    expect(user.email).to eql(mixed.downcase)
-  end
-
-  it "email validation should reject invalid addresses." do
-    invalid_addresses = %w[user@example,com user_at_foo.org user.name@example. foo@bar_baz.com foo@bar+baz.com]
-    user = create(:user)
-
-    invalid_addresses.each do |invalid_address|
-      user.email = invalid_address
-      expect(user).to_not be_valid
+    context 'is not greenlight account' do
+      before { allow(subject).to receive(:greenlight_account?).and_return(false) }
+      it { should_not validate_presence_of(:password) }
     end
   end
 
-  it "email should be unique." do
-    user = create(:user)
-    duplicate = user.dup
-
-    expect(duplicate).to_not be_valid
+  context 'associations' do
+    it { should belong_to(:main_room).class_name("Room").with_foreign_key("room_id") }
+    it { should have_many(:rooms) }
   end
 
-  it "name should not be too long." do
-    user = build(:user, name: "a" * 25)
-    expect(user).to_not be_valid
+  context '#initialize_main_room' do
+    it 'creates random uid and main_room' do
+      expect(@user.uid).to_not be_nil
+      expect(@user.main_room).to be_a(Room)
+    end
   end
 
-  it "email should not be too long." do
-    user = build(:user, email: "a" * 50 + "@example.com")
-    expect(user).to_not be_valid
+  context "#to_param" do
+    it "uses uid as the default identifier for routes" do
+      expect(@user.to_param).to eq(@user.uid)
+    end
   end
 
-  it "should generate room and meeting when saved." do
-    user = create(:user)
-    user.save
-
-    expect(user.room).to be_instance_of Room
-    expect(user.room.meeting).to be_instance_of Meeting
+  context '#first_name' do
+    it 'properly finds the users first name' do
+      user = create(:user, name: "Example User")
+      expect(user.firstname).to eq("Example")
+    end
   end
-end
+end