Added field to track users last login (#2367)

spec/controllers/sessions_controller_spec.rb

@@ -272,6 +272,19 @@ describe SessionsController, type: :controller do
         }
       }.to change { ActionMailer::Base.deliveries.count }.by(1)
     end
+
+    it "correctly sets the last_login field after the user is created" do
+      post :create, params: {
+        session: {
+          email: @user1.email,
+          password: 'example',
+        },
+      }
+
+      @user1.reload
+
+      expect(@user1.last_login).to_not be_nil
+    end
   end
 
   describe "GET/POST #omniauth" do
@@ -372,6 +385,15 @@ describe SessionsController, type: :controller do
       expect(response).to redirect_to(root_path)
     end
 
+    it "correctly sets the last_login field after the user is created" do
+      request.env["omniauth.auth"] = OmniAuth.config.mock_auth[:google]
+      get :omniauth, params: { provider: :google }
+
+      u = User.last
+
+      expect(u.last_login).to_not be_nil
+    end
+
     context 'twitter deprecation' do
       it "should not allow new user sign up with omniauth twitter" do
         request.env["omniauth.auth"] = OmniAuth.config.mock_auth[:twitter]

spec/controllers/users_controller_spec.rb

@@ -139,6 +139,15 @@ describe UsersController, type: :controller do
         expect(flash[:success]).to be_present
         expect(response).to redirect_to(root_path)
       end
+
+      it "correctly sets the last_login field after the user is created" do
+        params = random_valid_user_params
+        post :create, params: params
+
+        u = User.find_by(name: params[:user][:name], email: params[:user][:email])
+
+        expect(u.last_login).to_not be_nil
+      end
     end
 
     context "disallow greenlight accounts" do