lino.jorzick
/
greenlight
forked from External/greenlight
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add autofocus and required attributes (#2703) 

* Set required attribute to input fields

It is needed to type in a username and password. This attribute force it and reduce useless requests to the server and shows the user the problem directly.

* Update signin.html.erb

* add autofocus and required attributes

* add autofocus and required attributes

Co-authored-by: Ahmad Farhat <ahmad.af.farhat@gmail.com>
This commit is contained in:
Dennis1993 2021-06-08 01:13:00 +02:00 committed by GitHub
parent b61df09b94
commit 184ffdb288
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/views/sessions/ldap_signin.html.erb
View File

@ -12,7 +12,7 @@
<span class="input-icon-addon"> <span class="input-icon-addon">
<i class="fas fa-user"></i> <i class="fas fa-user"></i>
</span> </span>
<%= f.text_field :username, class: "form-control", placeholder: t("administrator.users.table.username"), value: "", autocomplete: "username", autocapitalize: "none", spellcheck: "false", autofocus: "" %> <%= f.text_field :username, class: "form-control", placeholder: t("administrator.users.table.username"), value: "", autocomplete: "username", autocapitalize: "none", spellcheck: "false", autofocus: "", required: "" %>
</div> </div>
</div> </div>
<div class="form-group"> <div class="form-group">
@ -20,7 +20,7 @@
<span class="input-icon-addon"> <span class="input-icon-addon">
<i class="fas fa-key"></i> <i class="fas fa-key"></i>
</span> </span>
<%= f.password_field :password, class: "form-control", placeholder: t("password"), value: "" %> <%= f.password_field :password, class: "form-control", placeholder: t("password"), value: "", required: "" %>
</div> </div>
</div> </div>
<div> <div>

8
app/views/sessions/new.html.erb
View File

@ -41,22 +41,22 @@
<%= form_for @user, url: create_user_path, method: :post do |f| %> <%= form_for @user, url: create_user_path, method: :post do |f| %>
<div class="form-group"> <div class="form-group">
<%= f.label :name, t("settings.account.fullname"), class: "form-label" %> <%= f.label :name, t("settings.account.fullname"), class: "form-label" %>
<%= f.text_field :name, class: "form-control #{form_is_invalid?(@user, :name)}", placeholder: t("settings.account.fullname") %> <%= f.text_field :name, class: "form-control #{form_is_invalid?(@user, :name)}", placeholder: t("settings.account.fullname"), autofocus: "", required: "" %>
<div class="invalid-feedback d-block"><%= @user.errors.full_messages_for(:name).first %></div> <div class="invalid-feedback d-block"><%= @user.errors.full_messages_for(:name).first %></div>
</div> </div>
<div class="form-group"> <div class="form-group">
<%= f.label :email, t("email"), class: "form-label" %> <%= f.label :email, t("email"), class: "form-label" %>
<%= f.email_field :email, class: "form-control #{form_is_invalid?(@user, :email)}", placeholder: t("email") %> <%= f.email_field :email, class: "form-control #{form_is_invalid?(@user, :email)}", placeholder: t("email"), required: "" %>
<div class="invalid-feedback d-block"><%= @user.errors.full_messages_for(:email).first %></div> <div class="invalid-feedback d-block"><%= @user.errors.full_messages_for(:email).first %></div>
</div> </div>
<div class="form-group"> <div class="form-group">
<%= f.label :password, t("password"), class: "form-label" %> <%= f.label :password, t("password"), class: "form-label" %>
<%= f.password_field :password, class: "form-control #{form_is_invalid?(@user, :password)}", placeholder: t("password") %> <%= f.password_field :password, class: "form-control #{form_is_invalid?(@user, :password)}", placeholder: t("password"), required: "" %>
<div class="invalid-feedback d-block"><%= @user.errors.full_messages_for(:password).first %></div> <div class="invalid-feedback d-block"><%= @user.errors.full_messages_for(:password).first %></div>
</div> </div>
<div class="form-group"> <div class="form-group">
<%= f.label :password_confirmation, t("signup.password_confirm"), class: "form-label" %> <%= f.label :password_confirmation, t("signup.password_confirm"), class: "form-label" %>
<%= f.password_field :password_confirmation, class: "form-control #{form_is_invalid?(@user, :password_confirmation)}", placeholder: t("signup.password_confirm") %> <%= f.password_field :password_confirmation, class: "form-control #{form_is_invalid?(@user, :password_confirmation)}", placeholder: t("signup.password_confirm"), required: "" %>
<div class="invalid-feedback d-block"><%= @user.errors.full_messages_for(:password_confirmation).first %></div> <div class="invalid-feedback d-block"><%= @user.errors.full_messages_for(:password_confirmation).first %></div>
</div> </div>
<% if Rails.configuration.terms %> <% if Rails.configuration.terms %>

4
app/views/sessions/signin.html.erb
View File

@ -44,7 +44,7 @@
<span class="input-icon-addon"> <span class="input-icon-addon">
<i class="fas fa-at"></i> <i class="fas fa-at"></i>
</span> </span>
<%= f.email_field :email, class: "form-control", placeholder: t("email"), value: "" %> <%= f.email_field :email, class: "form-control", placeholder: t("email"), value: "", autofocus: "", required: "" %>
</div> </div>
</div> </div>
<div class="form-group"> <div class="form-group">
@ -52,7 +52,7 @@
<span class="input-icon-addon"> <span class="input-icon-addon">
<i class="fas fa-key"></i> <i class="fas fa-key"></i>
</span> </span>
<%= f.password_field :password, class: "form-control", placeholder: t("password"), value: "" %> <%= f.password_field :password, class: "form-control", placeholder: t("password"), value: "", required: "" %>
</div> </div>
</div> </div>
<% if Rails.configuration.enable_email_verification %> <% if Rails.configuration.enable_email_verification %>