lino.jorzick
/
greenlight
forked from External/greenlight
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix some issues reported by LGTM (#1478) 

* Declare local JavaScript variables (reported by LGTM)

Signed-off-by: Stefan Weil <sw@weilnetz.de>

* Remove unused local JavaScript variable (reported by LGTM)

Signed-off-by: Stefan Weil <sw@weilnetz.de>
This commit is contained in:
Stefan Weil 2020-05-06 22:04:55 +02:00 committed by GitHub
parent ed7bec04b0
commit 2db50d3d68
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/assets/javascripts/admins.js
View File

@ -80,7 +80,7 @@ $(document).on('turbolinks:load', function(){
// Get the uid of the selected user // Get the uid of the selected user
let user = $(".selectpicker").selectpicker('val') let user = $(".selectpicker").selectpicker('val')
if (user != "") { if (user != "") {
userInfo = JSON.parse(user) let userInfo = JSON.parse(user)
$("#merge-from").html("<span>" + userInfo.name + "</span>" + "<span class='text-muted d-block'>" + userInfo.email + "</span>" + "<span id='from-uid' class='text-muted d-block'>" + userInfo.uid + "</span>") $("#merge-from").html("<span>" + userInfo.name + "</span>" + "<span class='text-muted d-block'>" + userInfo.email + "</span>" + "<span id='from-uid' class='text-muted d-block'>" + userInfo.uid + "</span>")
} }
}) })
@ -95,7 +95,7 @@ $(document).on('turbolinks:load', function(){
}) })
// Updates the colour picker to the correct colour // Updates the colour picker to the correct colour
role_colour = $("#role-colorinput-regular").data("colour") let role_colour = $("#role-colorinput-regular").data("colour")
$("#role-colorinput-regular").css("background-color", role_colour); $("#role-colorinput-regular").css("background-color", role_colour);
$("#role-colorinput-regular").css("border-color", role_colour); $("#role-colorinput-regular").css("border-color", role_colour);
@ -263,4 +263,4 @@ function loadRoleColourSelector(role_colour, disabled) {
$("#role-colour").val(color.toHEXA().toString()); $("#role-colour").val(color.toHEXA().toString());
}); });
} }
} }

3
app/assets/javascripts/room.js
View File

@ -138,7 +138,6 @@ $(document).on('turbolinks:load', function(){
}); });
function showCreateRoom(target) { function showCreateRoom(target) {
var modal = $(target)
$("#create-room-name").val("") $("#create-room-name").val("")
$("#create-room-access-code").text(getLocalizedString("modal.create_room.access_code_placeholder")) $("#create-room-access-code").text(getLocalizedString("modal.create_room.access_code_placeholder"))
$("#room_access_code").val(null) $("#room_access_code").val(null)
@ -269,4 +268,4 @@ function removeSharedUser(target) {
parentLI.removeChild(target) parentLI.removeChild(target)
parentLI.classList.add("remove-shared") parentLI.classList.add("remove-shared")
} }
} }