forked from External/greenlight
GRN2-174: Added 404 if user does not exist (#609)
* Added 404 if user does not exist * Differentiated between 404 and 500 * Rspec fixes
This commit is contained in:
committed by
Jesus Federico
parent
e4f50026f1
commit
5d4bd1b851
@ -131,10 +131,21 @@ class ApplicationController < ActionController::Base
|
||||
end
|
||||
|
||||
def set_user_domain
|
||||
@user_domain = if Rails.env.test? || !Rails.configuration.loadbalanced_configuration
|
||||
"greenlight"
|
||||
if Rails.env.test? || !Rails.configuration.loadbalanced_configuration
|
||||
@user_domain = "greenlight"
|
||||
else
|
||||
parse_user_domain(request.host)
|
||||
@user_domain = parse_user_domain(request.host)
|
||||
|
||||
# Checks to see if the user exists
|
||||
begin
|
||||
retrieve_provider_info(@user_domain, 'api2', 'getUserGreenlightCredentials')
|
||||
rescue => e
|
||||
if e.message.eql? "No user with that id exists"
|
||||
render "errors/not_found", locals: { user_not_found: true }
|
||||
else
|
||||
render "errors/internal_error"
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
helper_method :set_user_domain
|
||||
|
@ -15,9 +15,14 @@
|
||||
|
||||
<div class="container text-center pt-9">
|
||||
<div class="display-1 text-muted mb-5">404</div>
|
||||
<h1 class="h2 mb-3"><%= t("errors.not_found.message") %></h1>
|
||||
<p class="h4 text-muted font-weight-normal mb-7"><%= t("errors.not_found.help") %></p>
|
||||
<a class="btn btn-primary" href="javascript:history.back()">
|
||||
<i class="fas fa-arrow-left mr-2"></i><%= t("go_back") %>
|
||||
</a>
|
||||
<% if defined?(user_not_found) %>
|
||||
<h1 class="h2 mb-3"><%= t("errors.not_found.user_message") %></h1>
|
||||
<p class="h4 text-muted font-weight-normal mb-7"><%= t("errors.not_found.user_help") %></p>
|
||||
<% else %>
|
||||
<h1 class="h2 mb-3"><%= t("errors.not_found.message") %></h1>
|
||||
<p class="h4 text-muted font-weight-normal mb-7"><%= t("errors.not_found.help") %></p>
|
||||
<a class="btn btn-primary" href="javascript:history.back()">
|
||||
<i class="fas fa-arrow-left mr-2"></i><%= t("go_back") %>
|
||||
</a>
|
||||
<% end %>
|
||||
</div>
|
||||
|
Reference in New Issue
Block a user