GRN2-174: Added 404 if user does not exist (#609)

* Added 404 if user does not exist

* Differentiated between 404 and 500

* Rspec fixes

spec/controllers/application_controller_spec.rb

@@ -31,6 +31,10 @@ describe ApplicationController do
     def error
       raise BigBlueButton::BigBlueButtonException
     end
+
+    def user_not_found
+      set_user_domain
+    end
   end
 
   context "roles" do
@@ -66,5 +70,29 @@ describe ApplicationController do
       get :error
       expect(response).to render_template("errors/bigbluebutton_error")
     end
+
+    it "renders a 404 error if user is not found" do
+      allow(Rails.configuration).to receive(:loadbalanced_configuration).and_return(true)
+      allow(Rails.env).to receive(:test?).and_return(false)
+      allow_any_instance_of(SessionsHelper).to receive(:parse_user_domain).and_return("")
+      allow_any_instance_of(BbbApi).to receive(:retrieve_provider_info).and_raise("No user with that id exists")
+
+      routes.draw { get "user_not_found" => "anonymous#user_not_found" }
+
+      get :user_not_found
+      expect(response).to render_template("errors/not_found")
+    end
+
+    it "renders a 500 error if any other error is not found" do
+      allow(Rails.configuration).to receive(:loadbalanced_configuration).and_return(true)
+      allow(Rails.env).to receive(:test?).and_return(false)
+      allow_any_instance_of(SessionsHelper).to receive(:parse_user_domain).and_return("")
+      allow_any_instance_of(BbbApi).to receive(:retrieve_provider_info).and_raise("Other error")
+
+      routes.draw { get "user_not_found" => "anonymous#user_not_found" }
+
+      get :user_not_found
+      expect(response).to render_template("errors/internal_error")
+    end
   end
 end