From e915aba9db6438f8f3b2185ae3bdd3a5029508a6 Mon Sep 17 00:00:00 2001
From: jfederico <jesus@123it.ca>
Date: Wed, 9 Jan 2019 22:01:19 +0000
Subject: [PATCH] Updates to specs

---
 .../application_controller_spec.rb            | 47 -------------------
 .../password_resets_controller_spec.rb        | 14 +++---
 spec/spec_helper.rb                           | 30 ++++++++++++
 3 files changed, 37 insertions(+), 54 deletions(-)
 delete mode 100644 spec/controllers/application_controller_spec.rb

diff --git a/spec/controllers/application_controller_spec.rb b/spec/controllers/application_controller_spec.rb
deleted file mode 100644
index 6ce8e7d4..00000000
--- a/spec/controllers/application_controller_spec.rb
+++ /dev/null
@@ -1,47 +0,0 @@
-# frozen_string_literal: true
-
-# BigBlueButton open source conferencing system - http://www.bigbluebutton.org/.
-#
-# Copyright (c) 2018 BigBlueButton Inc. and by respective authors (see below).
-#
-# This program is free software; you can redistribute it and/or modify it under the
-# terms of the GNU Lesser General Public License as published by the Free Software
-# Foundation; either version 3.0 of the License, or (at your option) any later
-# version.
-#
-# BigBlueButton is distributed in the hope that it will be useful, but WITHOUT ANY
-# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A
-# PARTICULAR PURPOSE. See the GNU Lesser General Public License for more details.
-#
-# You should have received a copy of the GNU Lesser General Public License along
-# with BigBlueButton; if not, see <http://www.gnu.org/licenses/>.
-
-require "rails_helper"
-
-describe ApplicationController, type: :controller do
-  describe "Application Controller Tests" do
-    before { allow(Rails.configuration).to receive(:recording_thumbnails).and_return(true) }
-    before { allow(Rails.configuration).to receive(:bigbluebutton_endpoint).and_return(:defaultBBBendpoint) }
-    before { allow(Rails.configuration).to receive(:bigbluebutton_endpoint_default).and_return(:defaultBBBendpoint) }
-
-    it "verifies if recording thumnails exist" do
-      expect(controller.recording_thumbnails?).to eq(true)
-    end
-
-    it "verifies if bigbluebutton endpoint is default" do
-      expect(controller.bigbluebutton_endpoint_default?).to eq(true)
-    end
-
-    it "Returns meeting name limit" do
-      expect(controller.meeting_name_limit).to eq(90)
-    end
-
-    it "Returns user name limit" do
-      expect(controller.user_name_limit).to eq(32)
-    end
-
-    it "Returns relative root" do
-      expect(controller.relative_root).to eq("")
-    end
-  end
-end
diff --git a/spec/controllers/password_resets_controller_spec.rb b/spec/controllers/password_resets_controller_spec.rb
index 1fdd6b1f..18026ea3 100644
--- a/spec/controllers/password_resets_controller_spec.rb
+++ b/spec/controllers/password_resets_controller_spec.rb
@@ -79,8 +79,8 @@ describe PasswordResetsController, type: :controller do
       it "reloads page with notice if password is empty" do
         token = "reset_token"
 
-        controller.stub(:valid_user).and_return(nil)
-        controller.stub(:check_expiration).and_return(nil)
+        allow(controller).to receive(:valid_user).and_return(nil)
+        allow(controller).to receive(:check_expiration).and_return(nil)
 
         params = {
           id: token,
@@ -96,8 +96,8 @@ describe PasswordResetsController, type: :controller do
       it "reloads page with notice if password is confirmation doesn't match" do
         token = "reset_token"
 
-        controller.stub(:valid_user).and_return(nil)
-        controller.stub(:check_expiration).and_return(nil)
+        allow(controller).to receive(:valid_user).and_return(nil)
+        allow(controller).to receive(:check_expiration).and_return(nil)
 
         params = {
           id: token,
@@ -118,9 +118,9 @@ describe PasswordResetsController, type: :controller do
         cost = ActiveModel::SecurePassword.min_cost ? BCrypt::Engine::MIN_COST : BCrypt::Engine.cost
         user.reset_digest = BCrypt::Password.create(token, cost: cost)
 
-        controller.stub(:valid_user).and_return(nil)
-        controller.stub(:check_expiration).and_return(nil)
-        controller.stub(:current_user).and_return(user)
+        allow(controller).to receive(:valid_user).and_return(nil)
+        allow(controller).to receive(:check_expiration).and_return(nil)
+        allow(controller).to receive(:current_user).and_return(user)
 
         params = {
           id: token,
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
index bd82a506..17a3ad99 100644
--- a/spec/spec_helper.rb
+++ b/spec/spec_helper.rb
@@ -57,6 +57,36 @@ RSpec.configure do |config|
         }
       )
       .to_return(status: 200, body: "", headers: {})
+    stub_request(:any, /#{ENV['LOADBALANCER_ENDPOINT']}/)
+      .with(
+        headers:
+        {
+          'Accept': '*/*',
+          'Accept-Encoding': 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
+          'User-Agent': 'Ruby',
+        }
+      )
+      .to_return(status: 200, body: "", headers: {})
+    stub_request(:any, /#{ENV['LOADBALANCER_ENDPOINT'] + 'getUser'}/)
+      .with(
+        headers:
+        {
+          'Accept': '*/*',
+          'Accept-Encoding': 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
+          'User-Agent': 'Ruby',
+        }
+      )
+      .to_return(status: 200, body: "
+        <response>
+          <version>1.0</version>
+          <returncode>SUCCESS</returncode>
+          <user>
+            <name>greenlight</name>
+            <maxMeetings>1000</maxMeetings>
+            <apiURL>#{ENV['LOADBALANCER_ENDPOINT'] + 'api'}</apiURL>
+            <secret>#{ENV['BIGBLUEBUTTON_SECRET']}</secret>
+          </user>
+        </response>", headers: {}) if ENV['LOADBALANCER_ENDPOINT']
   end
 
   # rspec-expectations config goes here. You can use an alternate