GRN2-180: First stages of refactoring code for v2.4 (#748)

* Email rescues and authenticator concern

* Application controller and helper clean up

* Moved controller code out of helpers

* More helper and email clean up

* Cleaned up remaining helpers and create omniauth_options

* Controller code clean up

* restructured views structure

* Restructured role code

* Restructured profile and code clean up

* Master merge

* Added bbb server concern to deal with bbb calls

* Bug fixes and changes after changes

* rspec

* More rubocop fixes

spec/controllers/application_controller_spec.rb

@@ -63,6 +63,64 @@ describe ApplicationController do
     end
   end
 
+  context "getters" do
+    it "returns whether user signup is allowed" do
+      allow(Rails.configuration).to receive(:allow_user_signup).and_return(true)
+
+      expect(controller.allow_user_signup?).to eql(true)
+    end
+
+    it "returns whether the default bbb endpoint is being used" do
+      allow(Rails.configuration).to receive(:bigbluebutton_endpoint)
+        .and_return("http://test-install.blindsidenetworks.com/bigbluebutton/api/")
+      allow(Rails.configuration).to receive(:bigbluebutton_endpoint_default)
+        .and_return("http://test-install.blindsidenetworks.com/bigbluebutton/api/")
+
+      expect(controller.bigbluebutton_endpoint_default?).to eql(true)
+    end
+  end
+
+  context "allow_greenlight_accounts" do
+    it "allows if user sign up is turned on" do
+      allow(Rails.configuration).to receive(:loadbalanced_configuration).and_return(false)
+      allow(Rails.configuration).to receive(:allow_user_signup).and_return(true)
+
+      expect(controller.allow_greenlight_accounts?).to eql(true)
+    end
+
+    it "doesn't allow if user sign up is turned off" do
+      allow(Rails.configuration).to receive(:loadbalanced_configuration).and_return(false)
+      allow(Rails.configuration).to receive(:allow_user_signup).and_return(false)
+
+      expect(controller.allow_greenlight_accounts?).to eql(false)
+    end
+
+    it "doesn't allow if user_domain is blank" do
+      allow(Rails.configuration).to receive(:loadbalanced_configuration).and_return(true)
+      allow(Rails.configuration).to receive(:allow_user_signup).and_return(true)
+
+      expect(controller.allow_greenlight_accounts?).to eql(false)
+    end
+
+    it "allows if user provider is set to greenlight" do
+      allow(Rails.configuration).to receive(:loadbalanced_configuration).and_return(true)
+      allow(Rails.configuration).to receive(:allow_user_signup).and_return(true)
+      allow(controller).to receive(:retrieve_provider_info).and_return("provider" => "greenlight")
+      controller.instance_variable_set(:@user_domain, "provider1")
+
+      expect(controller.allow_greenlight_accounts?).to eql(true)
+    end
+
+    it "doesnt allow if user provider is not set to greenlight" do
+      allow(Rails.configuration).to receive(:loadbalanced_configuration).and_return(true)
+      allow(Rails.configuration).to receive(:allow_user_signup).and_return(true)
+      allow(controller).to receive(:retrieve_provider_info).and_return("provider" => "google")
+      controller.instance_variable_set(:@user_domain, "provider1")
+
+      expect(controller.allow_greenlight_accounts?).to eql(false)
+    end
+  end
+
   context "errors" do
     it "renders a BigBlueButton error if a BigBlueButtonException occurrs" do
       routes.draw { get "error" => "anonymous#error" }
@@ -74,7 +132,7 @@ describe ApplicationController do
     it "renders a 404 error if user is not found" do
       allow(Rails.configuration).to receive(:loadbalanced_configuration).and_return(true)
       allow(Rails.env).to receive(:test?).and_return(false)
-      allow_any_instance_of(SessionsHelper).to receive(:parse_user_domain).and_return("fake_provider")
+      allow_any_instance_of(ApplicationController).to receive(:parse_user_domain).and_return("fake_provider")
       allow_any_instance_of(BbbApi).to receive(:retrieve_provider_info).and_raise("No user with that id exists")
 
       routes.draw { get "user_not_found" => "anonymous#user_not_found" }
@@ -86,7 +144,7 @@ describe ApplicationController do
     it "renders a 404 error if user is not given" do
       allow(Rails.configuration).to receive(:loadbalanced_configuration).and_return(true)
       allow(Rails.env).to receive(:test?).and_return(false)
-      allow_any_instance_of(SessionsHelper).to receive(:parse_user_domain).and_return("")
+      allow_any_instance_of(ApplicationController).to receive(:parse_user_domain).and_return("")
       allow_any_instance_of(BbbApi).to receive(:retrieve_provider_info).and_raise("Provider not included.")
 
       routes.draw { get "user_not_found" => "anonymous#user_not_found" }
@@ -98,7 +156,7 @@ describe ApplicationController do
     it "renders a 500 error if any other error related to bbb api" do
       allow(Rails.configuration).to receive(:loadbalanced_configuration).and_return(true)
       allow(Rails.env).to receive(:test?).and_return(false)
-      allow_any_instance_of(SessionsHelper).to receive(:parse_user_domain).and_return("")
+      allow_any_instance_of(ApplicationController).to receive(:parse_user_domain).and_return("")
       allow_any_instance_of(BbbApi).to receive(:retrieve_provider_info).and_raise("Other error")
 
       routes.draw { get "user_not_found" => "anonymous#user_not_found" }