From 05739278510183ba3b95ebc71ce49a1e69ec40fb Mon Sep 17 00:00:00 2001 From: Zachary Chai Date: Tue, 29 Nov 2016 14:58:01 -0500 Subject: [PATCH 1/2] add basic tests --- app/lib/bbb_api.rb | 4 ++-- test/controllers/landing_controller_test.rb | 25 +++++++++++++++++++-- test/fixtures/users.yml | 12 +++++----- test/models/user_test.rb | 19 +++++++++++++--- 4 files changed, 47 insertions(+), 13 deletions(-) diff --git a/app/lib/bbb_api.rb b/app/lib/bbb_api.rb index 890605de..4ff972d5 100644 --- a/app/lib/bbb_api.rb +++ b/app/lib/bbb_api.rb @@ -1,10 +1,10 @@ module BbbApi def bbb_endpoint - Rails.configuration.bigbluebutton_endpoint + Rails.configuration.bigbluebutton_endpoint || '' end def bbb_secret - Rails.configuration.bigbluebutton_secret + Rails.configuration.bigbluebutton_secret || '' end def bbb diff --git a/test/controllers/landing_controller_test.rb b/test/controllers/landing_controller_test.rb index 09f0ec6f..11db2e06 100644 --- a/test/controllers/landing_controller_test.rb +++ b/test/controllers/landing_controller_test.rb @@ -1,13 +1,34 @@ require 'test_helper' class LandingControllerTest < ActionController::TestCase + + setup do + @meeting_id = rand 100000000..999999999 + @user = users :user1 + end + test "should get index" do - get :index + get :index, params: {resource: 'meetings'} + assert_response :success + end + + test "should get meeting" do + get :resource, params: { id: @meeting_id, resource: 'meetings' } assert_response :success end test "should get room" do - get :room, params: { name: 'user1' } + get :resource, params: { id: @user.encrypted_id, resource: 'rooms' } + assert_response :success + end + + test "should get wait for moderator" do + get :wait_for_moderator, params: { id: @user.encrypted_id, resource: 'rooms' } + assert_response :success + end + + test "should get session status refresh" do + get :wait_for_moderator, params: { id: @user.encrypted_id, resource: 'rooms' } assert_response :success end diff --git a/test/fixtures/users.yml b/test/fixtures/users.yml index 462ae2b1..4f081bc2 100644 --- a/test/fixtures/users.yml +++ b/test/fixtures/users.yml @@ -1,15 +1,15 @@ # Read about fixtures at http://api.rubyonrails.org/classes/ActiveRecord/FixtureSet.html -one: +user1: provider: twitter uid: <%= SecureRandom.hex(10) %> - encrypted_id: user1 - name: User 1 username: user1 + encrypted_id: u2-<%= SecureRandom.hex(8) %> + name: User 1 -two: +user2: provider: google uid: <%= SecureRandom.hex(10) %> - encrypted_id: user2 - name: User 2 username: user2 + encrypted_id: u1-<%= SecureRandom.hex(8) %> + name: User 2 diff --git a/test/models/user_test.rb b/test/models/user_test.rb index 82f61e01..7aeca446 100644 --- a/test/models/user_test.rb +++ b/test/models/user_test.rb @@ -1,7 +1,20 @@ require 'test_helper' class UserTest < ActiveSupport::TestCase - # test "the truth" do - # assert true - # end + + test "should create user from omniauth" do + uid = '354545' + provider = 'twitter' + name = 'user name' + username = 'username' + + assert_difference 'User.count' do + User.from_omniauth({'uid' => uid, 'provider' => provider, 'info' => {'name' => name, 'nickname' => username}}) + end + + user = User.find_by uid: uid, provider: provider + assert_not_nil user.encrypted_id + assert user.username, username + assert user.name, name + end end From 693cb3202b6d46fe5cb64d3189cd9643e45314ad Mon Sep 17 00:00:00 2001 From: Zachary Chai Date: Tue, 29 Nov 2016 15:21:54 -0500 Subject: [PATCH 2/2] lock ruby version --- Gemfile | 1 + Gemfile.lock | 3 +++ 2 files changed, 4 insertions(+) diff --git a/Gemfile b/Gemfile index 3d5b03a1..9b584f9b 100644 --- a/Gemfile +++ b/Gemfile @@ -1,5 +1,6 @@ source 'https://rubygems.org' +ruby '2.3.1' # Bundle edge Rails instead: gem 'rails', github: 'rails/rails' gem 'rails', '~> 5.0.0', '>= 5.0.0.1' diff --git a/Gemfile.lock b/Gemfile.lock index e133b2f5..ba66b8b8 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -233,5 +233,8 @@ DEPENDENCIES uglifier (>= 1.3.0) web-console +RUBY VERSION + ruby 2.3.1p112 + BUNDLED WITH 1.13.5