Commit Graph

3 Commits

Author SHA1 Message Date
Dennis1993 184ffdb288
Add autofocus and required attributes (#2703)
* Set required attribute to input fields

It is needed to type in a username and password. This attribute force it and reduce useless requests to the server and shows the user the problem directly.

* Update signin.html.erb

* add autofocus and required attributes

* add autofocus and required attributes

Co-authored-by: Ahmad Farhat <ahmad.af.farhat@gmail.com>
2021-06-07 19:13:00 -04:00
felix-itz 5760bea00b
LDAP Sign-In form: user field attributes (#2014)
- autocomplete="username": Tell the browser a user name should be filled, if any.
  Reference: https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete
- autocapitalize="none": Tell browsers (especially on mobile devices like iOS) not to
  capitalize the first letter
  Reference: https://developer.apple.com/library/archive/documentation/AppleApplications/Reference/SafariHTMLRef/Articles/Attributes.html#//apple_ref/doc/uid/TP40008058-autocapitalize
- spellcheck="false": Do not spell-check the user name
  Reference: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/spellcheck
- autofocus: indicates that the input should automatically have focus, which makes sense
  because this form is shown after having clicked the "login" button so it's not an issue that
  the screen reader will skip the "Sign in to your account" text.
  Reference: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#htmlattrdefautofocus

This PR will improve usability especially on mobile devices. It does *not* not attempt to improve WCAG compliance.

Co-authored-by: Ahmad Farhat <ahmad.af.farhat@gmail.com>
2020-08-26 14:03:19 -04:00
farhatahmad 01b8dbbd0e GRN2-196: Fixed issues that scrutinizer is complaining about (#765)
* Refactored code to improve scrutinizer score

* Bug fixes
2019-09-19 10:03:44 -04:00